Skip to content

Conversation

@abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Oct 4, 2023

This is a follow up on the previous CI changes.

  • Avoid confusing PIP_NO_BUILD_ISOLATION.
    The latest version of cibuildwheel allows passing arguments directly to the build frontend CLI.
  • Update auditwheel (via pip) to remove incompatibility with wheel's latest version (due to de-vendoring of auditwheel by the container's OS package manager).
  • Cap on cffi<1.16 for mingw.

The latest version of `cibuildwheel` allows passing arguments directly
to the build frontend CLI.
@abravalheri abravalheri marked this pull request as ready for review October 4, 2023 12:00
@abravalheri
Copy link
Contributor Author

Hi @davidhewitt, it seems that cffi 1.16 started breaking for mingw...
I noticed that in https://github.com/PyO3/setuptools-rust/actions/runs/6404823991/job/17386133529, a completely unrelated change in the cibuildwheel workflow.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for this!

Capping cffi seems fine for now, can dig another time when it comes to it, ultimately it shouldn't matter for us in CI.

@davidhewitt davidhewitt merged commit c9dcdbf into PyO3:main Oct 4, 2023
@abravalheri abravalheri deleted the update-tests branch October 6, 2023 10:34
@abravalheri
Copy link
Contributor Author

I opened python-cffi/cffi#21, but maybe the problem is in setuptools itself.
Any suggestions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants